basepeak-ai/workspace-provider
Watch
6
0
Fork
You've already forked workspace-provider
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: s3 support path-style access #18

Merged
iwilltry42 merged 2 commits from feat/s3-path-style into main 2025-03-14 10:14:03 +00:00
Conversation 6 Commits 2 Files changed 6 +724 -625
iwilltry42 commented 2025-03-07 15:04:52 +00:00 (Migrated from github.com)
Copy link

e.g. for MinIO

Issue: https://github.com/obot-platform/obot/issues/1970

e.g. for MinIO Issue: https://github.com/obot-platform/obot/issues/1970
thedadams commented 2025-03-07 23:49:46 +00:00 (Migrated from github.com)
Copy link

It looks like this new configuration parameter is being correctly propagated, but I don't see where it is getting used.

Also, does it make sense to have tests for this? I am trying to keep the tests up to date in this repo.

It looks like this new configuration parameter is being correctly propagated, but I don't see where it is getting used. Also, does it make sense to have tests for this? I am trying to keep the tests up to date in this repo.
iwilltry42 commented 2025-03-10 14:40:29 +00:00 (Migrated from github.com)
Copy link

@thedadams it's used for configuring the S3 client: https://github.com/gptscript-ai/workspace-provider/pull/18/files#diff-bacdf9ec88bbacf70ff21d10982757707e431edec6834b5f4be628749e1a5d35R34

@thedadams it's used for configuring the S3 client: https://github.com/gptscript-ai/workspace-provider/pull/18/files#diff-bacdf9ec88bbacf70ff21d10982757707e431edec6834b5f4be628749e1a5d35R34
👍 1
g-linville (Migrated from github.com) approved these changes 2025-03-10 15:52:24 +00:00
iwilltry42 commented 2025-03-11 13:11:56 +00:00 (Migrated from github.com)
Copy link

@thedadams - added the tests and also tested with a local MinIO instance - all seems to be working fine 👍

@thedadams - added the tests and also tested with a local MinIO instance - all seems to be working fine :+1:
thedadams (Migrated from github.com) approved these changes 2025-03-13 17:55:01 +00:00
thedadams (Migrated from github.com) left a comment
Copy link

Looks good after conflicts are resolved.

Looks good after conflicts are resolved.
njhale (Migrated from github.com) approved these changes 2025-03-13 18:08:07 +00:00
njhale (Migrated from github.com) left a comment
Copy link

lgtm, assuming conflict resolution is uneventful

lgtm, assuming conflict resolution is uneventful
Sign in to join this conversation.
Reviewers
No reviewers
g-linville
thedadams
njhale
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
basepeak-ai/workspace-provider!18
No description provided.