fix(version): report module version for go install #24

Merged

thklein merged 2 commits from fix/version-from-buildinfo into main 2026-10-18 10:43:55 +00:00

Conversation 1 Commits 2 Files changed 2 +85 -2

thklein commented 2026-10-18 10:29:59 +00:00

Owner

Copy link

go install git.basepeak.dev/basepeak-ai/gptscript@v0.9.10 builds a binary that reports gptscript version v0.0.0-dev, because only goreleaser sets version.Tag via ldflags.

This falls back to the main module version from debug.ReadBuildInfo() when the tag is still the default. Release builds (ldflags) are unchanged; local go build (module version (devel)) keeps v0.0.0-dev.

Tested with a table test for resolveTag (ldflags wins, go-install module version, (devel), no build info). go vet / golangci-lint clean on the package.

`go install git.basepeak.dev/basepeak-ai/gptscript@v0.9.10` builds a binary that reports `gptscript version v0.0.0-dev`, because only goreleaser sets `version.Tag` via ldflags. This falls back to the main module version from `debug.ReadBuildInfo()` when the tag is still the default. Release builds (ldflags) are unchanged; local `go build` (module version `(devel)`) keeps `v0.0.0-dev`. Tested with a table test for `resolveTag` (ldflags wins, go-install module version, `(devel)`, no build info). `go vet` / golangci-lint clean on the package.

thklein added 1 commit 2026-10-18 10:30:00 +00:00

fix(version): report module version for go install ... f235f7a2e7

Release binaries get the tag via goreleaser ldflags, but
`go install git.basepeak.dev/basepeak-ai/gptscript@v0.9.10` printed
v0.0.0-dev. Fall back to the main module version from the build info
when the tag was not set at link time.

thklein commented 2026-10-18 10:43:43 +00:00

Author

Owner

Copy link

Review follow-up: since Go 1.24, go build in a checkout stamps a pseudo-version (with +dirty) into the build info, so the first version doubled the commit suffix for local/make build builds. The fallback now only applies when the build info has no vcs.revision (module-cache go install builds); added a test for the checkout case. Release builds (ldflags) and go install @vX / @branch verified unchanged.

Review follow-up: since Go 1.24, `go build` in a checkout stamps a pseudo-version (with `+dirty`) into the build info, so the first version doubled the commit suffix for local/`make build` builds. The fallback now only applies when the build info has no `vcs.revision` (module-cache `go install` builds); added a test for the checkout case. Release builds (ldflags) and `go install @vX` / `@branch` verified unchanged.

thklein added 1 commit 2026-10-18 10:43:44 +00:00

fix(version): skip module version for VCS builds ... 644811c8b1

Since Go 1.24 a local go build stamps a pseudo-version into the
build info, which made String() print the commit twice. Only fall
back when there is no vcs.revision, as with module-cache builds.

thklein merged commit 7299ab7999 into main 2026-10-18 10:43:55 +00:00

thklein deleted branch fix/version-from-buildinfo 2026-10-18 10:43:55 +00:00

thklein referenced this pull request from a commit 2026-10-18 10:43:55 +00:00

fix(version): report module version for go install (#24)

thklein referenced this pull request 2026-10-18 12:12:49 +00:00

test(version): match package nolint for revive #26

thklein referenced this pull request from a commit 2026-10-18 12:19:45 +00:00

test(version): match package nolint for revive (#26)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/engine

  

clarity/clear

  

enhancement

  

security

  

size/M

No labels

area/engine

clarity/clear

enhancement

security

size/M

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

basepeak-ai/gptscript!24

No description provided.